src/objects.cc - Issue 421913006: Version 3.28.43.1 (merged r22638)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 421913006: Version 3.28.43.1 (merged r22638) (Closed) Base URL: https://v8.googlecode.com/svn/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 4d08b7999ed27c317b41109f381eafb8d25575c3..01c0831b4ca5001950197e3931dc8a38a5d65889 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -4093,7 +4093,8 @@ void JSObject::AddProperty(Handle<JSObject> object, Handle<Name> name,

ASSERT(!object->IsJSProxy());

ASSERT(!name->AsArrayIndex(&index));

LookupIterator it(object, name, LookupIterator::CHECK_OWN_REAL);

- GetPropertyAttributes(&it);

+ Maybe<PropertyAttributes> maybe = GetPropertyAttributes(&it);

+ ASSERT(maybe.has_value);

ASSERT(!it.IsFound());

ASSERT(object->map()->is_extensible());

#endif

« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »