Linux accelerators cleanup

chrome/browser/tab_contents/web_contents_view_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/web_contents_view_gtk.h"
 
 #include <gdk/gdk.h>
 #include <gdk/gdkkeysyms.h>
 #include <gtk/gtk.h>
 
@@ skipping 144 matching lines @@
 void WebContentsViewGtk::UpdateDragCursor(bool is_drop_target) {
   NOTIMPLEMENTED();
 }
 
 // This is called when we the renderer asks us to take focus back (i.e., it has
 // iterated past the last focusable element on the page).
 void WebContentsViewGtk::TakeFocus(bool reverse) {
   web_contents_->delegate()->SetFocusToLocationBar();
 }
 
-
 void WebContentsViewGtk::HandleKeyboardEvent(
     const NativeWebKeyboardEvent& event) {
   // The renderer returned a keyboard event it did not process. This may be a
   // keyboard shortcut that we have to process or a cursor key/page up/down
   // etc.
   switch (event.os_event->keyval) {
     case GDK_Page_Up:
     case GDK_Page_Down:
     case GDK_Left:
     case GDK_Right:
     case GDK_Up:
     case GDK_Down:
       NOTIMPLEMENTED()
           << "Need better navigation support in HandleKeyboardEvent";
       break;
     default:
       // This may be an accelerator. Pass it on to GTK.
-      gtk_accel_groups_activate(G_OBJECT(vbox_->window),
-                                event.os_event->keyval,
+      GtkWindow* window = GetTopLevelNativeView();

[Dean McNamee, 2009/03/16 19:19:02]

GetTopLevelNativeView returning a Window still seems wrong... Can you fix it?

[Evan Stade, 2009/03/16 19:25:49]

will change the name of that function in a follow up patch as it touches a
numebr of files.

+      gtk_accel_groups_activate(G_OBJECT(window), event.os_event->keyval,
                                 GdkModifierType(event.os_event->state));
   }
 }
 
 void WebContentsViewGtk::OnFindReply(int request_id,
                                      int number_of_matches,
                                      const gfx::Rect& selection_rect,
                                      int active_match_ordinal,
                                      bool final_update) {
   NOTIMPLEMENTED();
@@ skipping 28 matching lines @@
     const gfx::Rect& initial_pos,
     bool user_gesture) {
   NOTIMPLEMENTED();
 }
 
 void WebContentsViewGtk::ShowCreatedWidgetInternal(
     RenderWidgetHostView* widget_host_view,
     const gfx::Rect& initial_pos) {
   NOTIMPLEMENTED();
 }