Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: Source/core/svg/SVGGraphicsElement.cpp

Issue 421863002: SVGElement::parseAttribute resolves property via property map (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add return Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGRectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGGraphicsElement.cpp
diff --git a/Source/core/svg/SVGGraphicsElement.cpp b/Source/core/svg/SVGGraphicsElement.cpp
index 75debeb992e1dfd5af2b41c58ec64952808d5c47..08e178a6969d1cfb0b55bb502638960209e31e5e 100644
--- a/Source/core/svg/SVGGraphicsElement.cpp
+++ b/Source/core/svg/SVGGraphicsElement.cpp
@@ -179,21 +179,7 @@ bool SVGGraphicsElement::isSupportedAttribute(const QualifiedName& attrName)
void SVGGraphicsElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- if (!isSupportedAttribute(name)) {
- SVGElement::parseAttribute(name, value);
- return;
- }
-
- SVGParsingError parseError = NoError;
-
- if (name == SVGNames::transformAttr)
- m_transform->setBaseValueAsString(value, parseError);
- else if (SVGTests::parseAttribute(name, value))
- return;
- else
- ASSERT_NOT_REACHED();
-
- reportAttributeParsingError(parseError, name, value);
+ parseAttributeNew(name, value);
}
void SVGGraphicsElement::svgAttributeChanged(const QualifiedName& attrName)
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGRectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698