Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: Source/core/svg/SVGRectElement.cpp

Issue 421863002: SVGElement::parseAttribute resolves property via property map (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGRectElement.cpp
diff --git a/Source/core/svg/SVGRectElement.cpp b/Source/core/svg/SVGRectElement.cpp
index 66fdbe809fa382b1d315062345055e5b4f4ec85a..c141e9233a1e26d9199d1ce457bd72732c682b98 100644
--- a/Source/core/svg/SVGRectElement.cpp
+++ b/Source/core/svg/SVGRectElement.cpp
@@ -65,26 +65,7 @@ bool SVGRectElement::isSupportedAttribute(const QualifiedName& attrName)
void SVGRectElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- SVGParsingError parseError = NoError;
-
- if (!isSupportedAttribute(name))
- SVGGeometryElement::parseAttribute(name, value);
- else if (name == SVGNames::xAttr)
- m_x->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::yAttr)
- m_y->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::rxAttr)
- m_rx->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::ryAttr)
- m_ry->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::widthAttr)
- m_width->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::heightAttr)
- m_height->setBaseValueAsString(value, parseError);
- else
- ASSERT_NOT_REACHED();
-
- reportAttributeParsingError(parseError, name, value);
+ parseAttributeNew(name, value);
}
void SVGRectElement::svgAttributeChanged(const QualifiedName& attrName)

Powered by Google App Engine
This is Rietveld 408576698