Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: Source/core/svg/SVGElement.h

Issue 421863002: SVGElement::parseAttribute resolves property via property map (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add return Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAnimatedLength.h ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2009, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2009, 2014 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 189
190 virtual void trace(Visitor*) OVERRIDE; 190 virtual void trace(Visitor*) OVERRIDE;
191 191
192 static const AtomicString& eventParameterName(); 192 static const AtomicString& eventParameterName();
193 193
194 protected: 194 protected:
195 SVGElement(const QualifiedName&, Document&, ConstructionType = CreateSVGElem ent); 195 SVGElement(const QualifiedName&, Document&, ConstructionType = CreateSVGElem ent);
196 196
197 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE; 197 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;
198 198
199 // FIXME: |parseAttributeNew| is a new implementation of parseAttribute
200 // which maps attribute using |m_newAttributeToPropertyMap|.
201 // This is to replace |parseAttribute()| after all derived class switch to c all this.
202 void parseAttributeNew(const QualifiedName&, const AtomicString&);
203
199 virtual void attributeChanged(const QualifiedName&, const AtomicString&, Att ributeModificationReason = ModifiedDirectly) OVERRIDE; 204 virtual void attributeChanged(const QualifiedName&, const AtomicString&, Att ributeModificationReason = ModifiedDirectly) OVERRIDE;
200 205
201 virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE; 206 virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;
202 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) OVERRIDE; 207 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) OVERRIDE;
203 208
204 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE; 209 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
205 virtual void removedFrom(ContainerNode*) OVERRIDE; 210 virtual void removedFrom(ContainerNode*) OVERRIDE;
206 virtual void childrenChanged(const ChildrenChange&) OVERRIDE; 211 virtual void childrenChanged(const ChildrenChange&) OVERRIDE;
207 212
208 static CSSPropertyID cssPropertyIdForSVGAttributeName(const QualifiedName&); 213 static CSSPropertyID cssPropertyIdForSVGAttributeName(const QualifiedName&);
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 template<typename T> inline bool is##thisType(const PassRefPtr<T>& node) { r eturn is##thisType(node.get()); } \ 289 template<typename T> inline bool is##thisType(const PassRefPtr<T>& node) { r eturn is##thisType(node.get()); } \
285 template<typename T> inline bool is##thisType(const RefPtr<T>& node) { retur n is##thisType(node.get()); } \ 290 template<typename T> inline bool is##thisType(const RefPtr<T>& node) { retur n is##thisType(node.get()); } \
286 template <> inline bool isElementOfType<const thisType>(const SVGElement& el ement) { return is##thisType(element); } \ 291 template <> inline bool isElementOfType<const thisType>(const SVGElement& el ement) { return is##thisType(element); } \
287 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType) 292 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)
288 293
289 } 294 }
290 295
291 #include "core/SVGElementTypeHelpers.h" 296 #include "core/SVGElementTypeHelpers.h"
292 297
293 #endif 298 #endif
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAnimatedLength.h ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698