Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 421853002: Use baked CSS colors instead of opacity for flakiness interpolated results (Closed)

Created:
6 years, 4 months ago by pdr.
Modified:
6 years, 4 months ago
Reviewers:
jparent, ojan, eseidel
CC:
blink-reviews, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Use baked CSS colors instead of opacity for flakiness interpolated results Chrome does not handle large numbers of layers well and the flakiness dashboard was creating thousands of them (one for each interpolated result.) This patch switches to manually calculating the opacity value and baking it into the css. This is less maintainable but avoids expensive non-zero opacity layers. http://hex2rgba.devoth.com is a simple tool I used to calculate the 20% opacity version of the test result colors. NOTRY=true TEST=manual. With this patch applied, the flakiness dashboard scrolls smoothly. BUG=397886 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.css View 2 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pdr.
6 years, 4 months ago (2014-07-28 00:35:17 UTC) #1
eseidel
lgtm sad but true.
6 years, 4 months ago (2014-07-28 00:55:03 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 4 months ago (2014-07-28 01:16:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/421853002/1
6 years, 4 months ago (2014-07-28 01:17:30 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 01:17:59 UTC) #5
Message was sent while issue was closed.
Change committed as 178994

Powered by Google App Engine
This is Rietveld 408576698