Chromium Code Reviews

Issue 421823002: Remove SVGFEMorphologyElement.setRadius(radiusX, radiusY) (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
jochen (gone - plz use gerrit)
CC:
arv+blink, blink-reviews, Inactive, krit, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr., rwlbuis, Stephen Chennney
Project:
blink
Visibility:
Public.

Description

Remove SVGFEMorphologyElement.setRadius(radiusX, radiusY) Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/cQWSsX1jHMQ/h-sAaqRqnbUJ BUG=398791 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179216

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Stats (+1 line, -14 lines)
M LayoutTests/svg/dynamic-updates/script-tests/SVGFEMorphologyElement-svgdom-radius-call.js View 1 chunk +1 line, -1 line 0 comments
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments
M Source/core/svg/SVGFEMorphologyElement.h View 1 chunk +0 lines, -2 lines 0 comments
M Source/core/svg/SVGFEMorphologyElement.cpp View 1 chunk +0 lines, -7 lines 0 comments
M Source/core/svg/SVGFEMorphologyElement.idl View 1 chunk +0 lines, -3 lines 0 comments

Messages

Total messages: 6 (0 generated)
philipj_slow
fix test
6 years, 4 months ago (2014-07-28 09:50:30 UTC) #1
philipj_slow
PTAL
6 years, 4 months ago (2014-07-30 08:42:16 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-30 09:23:07 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-30 09:25:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/421823002/20001
6 years, 4 months ago (2014-07-30 09:25:59 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 09:29:16 UTC) #6
Message was sent while issue was closed.
Change committed as 179216

Powered by Google App Engine