Use tighter typing in editing: IndentOutdentCommand / InsertListCommand

Use tighter typing in editing: IndentOutdentCommand / InsertListCommand

Use tighter typing in editing to increase code readability and avoid unnecessary
type checks. This CL focuses on IndentOutdentCommand and InsertListCommand.

R=leviw@chromium.org, yosin@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179195

[yosin_UTC9, 2014-07-28 00:57:19]

LGTM

It is more readabile. Thanks!
Please wait for OWNERS lgtm for committing.

[Inactive, 2014-07-29 12:01:53]

On 2014/07/28 00:57:19, Yosi_UTC9 wrote:
> LGTM
> 
> It is more readabile. Thanks!
> Please wait for OWNERS lgtm for committing.

Thanks, Levi, can you please take a look?

[leviw_travelin_and_unemployed, 2014-07-29 20:01:48]

lgtm

[Inactive, 2014-07-29 20:13:32]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-29 20:14:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/421793002/20001

[commit-bot: I haz the power, 2014-07-29 20:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 20:14:16]

Failed to apply patch for Source/core/editing/CompositeEditCommand.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/editing/CompositeEditCommand.cpp
  Hunk #1 succeeded at 1115 (offset 3 lines).
  Hunk #2 FAILED at 1323.
  Hunk #3 FAILED at 1337.
  2 out of 3 hunks FAILED -- saving rejects to file
Source/core/editing/CompositeEditCommand.cpp.rej

Patch:       Source/core/editing/CompositeEditCommand.cpp
Index: Source/core/editing/CompositeEditCommand.cpp
diff --git a/Source/core/editing/CompositeEditCommand.cpp
b/Source/core/editing/CompositeEditCommand.cpp
index
5a50f50284f2f632e07c45cf989486b76371c3a0..ca4b9e2e664f86b6e47d6c21403d0598d7256615
100644
--- a/Source/core/editing/CompositeEditCommand.cpp
+++ b/Source/core/editing/CompositeEditCommand.cpp
@@ -1112,7 +1112,7 @@ void
CompositeEditCommand::cleanupAfterDeletion(VisiblePosition destination)
 // The blockElement parameter is the element to move the paragraph to,
 // outerNode is the top element of the paragraph hierarchy.
 
-void CompositeEditCommand::moveParagraphWithClones(const VisiblePosition&
startOfParagraphToMove, const VisiblePosition& endOfParagraphToMove, Element*
blockElement, Node* outerNode)
+void CompositeEditCommand::moveParagraphWithClones(const VisiblePosition&
startOfParagraphToMove, const VisiblePosition& endOfParagraphToMove,
HTMLElement* blockElement, Node* outerNode)
 {
     ASSERT(outerNode);
     ASSERT(blockElement);
@@ -1323,9 +1323,9 @@ bool CompositeEditCommand::breakOutOfEmptyListItem()
 
     RefPtrWillBeRawPtr<Node> previousListNode = emptyListItem->isElementNode()
? ElementTraversal::previousSibling(*emptyListItem):
emptyListItem->previousSibling();
     RefPtrWillBeRawPtr<Node> nextListNode = emptyListItem->isElementNode() ?
ElementTraversal::nextSibling(*emptyListItem): emptyListItem->nextSibling();
-    if (isListItem(nextListNode.get()) || isListElement(nextListNode.get())) {
+    if (isListItem(nextListNode.get()) ||
isHTMLListElement(nextListNode.get())) {
         // If emptyListItem follows another list item or nested list, split the
list node.
-        if (isListItem(previousListNode.get()) ||
isListElement(previousListNode.get()))
+        if (isListItem(previousListNode.get()) ||
isHTMLListElement(previousListNode.get()))
             splitElement(toElement(listNode), emptyListItem);
 
         // If emptyListItem is followed by other list item or nested list, then
insert newBlock before the list node.
@@ -1337,7 +1337,7 @@ bool CompositeEditCommand::breakOutOfEmptyListItem()
         // When emptyListItem does not follow any list item or nested list,
insert newBlock after the enclosing list node.
         // Remove the enclosing node if emptyListItem is the only child;
otherwise just remove emptyListItem.
         insertNodeAfter(newBlock, listNode);
-        removeNode(isListItem(previousListNode.get()) ||
isListElement(previousListNode.get()) ? emptyListItem.get() : listNode.get());
+        removeNode(isListItem(previousListNode.get()) ||
isHTMLListElement(previousListNode.get()) ? emptyListItem.get() :
listNode.get());
     }
 
     appendBlockPlaceholder(newBlock);

[Inactive, 2014-07-29 20:40:28]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-29 20:41:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/421793002/40001

[commit-bot: I haz the power, 2014-07-29 22:03:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-07-29 23:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 23:07:16]

Failed to apply patch for
Source/core/editing/InsertParagraphSeparatorCommand.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/editing/InsertParagraphSeparatorCommand.cpp
  Hunk #1 FAILED at 168.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/editing/InsertParagraphSeparatorCommand.cpp.rej

Patch:       Source/core/editing/InsertParagraphSeparatorCommand.cpp
Index: Source/core/editing/InsertParagraphSeparatorCommand.cpp
diff --git a/Source/core/editing/InsertParagraphSeparatorCommand.cpp
b/Source/core/editing/InsertParagraphSeparatorCommand.cpp
index
e2cbdcffc5e04364ce3b74cbeb721f65ab5c22bd..dd228fb2ade763755194c882e654a15718c68dc6
100644
--- a/Source/core/editing/InsertParagraphSeparatorCommand.cpp
+++ b/Source/core/editing/InsertParagraphSeparatorCommand.cpp
@@ -168,7 +168,7 @@ void InsertParagraphSeparatorCommand::doApply()
     // FIXME: The parentAnchoredEquivalent conversion needs to be moved into
enclosingBlock.
     RefPtrWillBeRawPtr<Element> startBlock =
enclosingBlock(insertionPosition.parentAnchoredEquivalent().containerNode());
     Node* listChildNode =
enclosingListChild(insertionPosition.parentAnchoredEquivalent().containerNode());
-    RefPtrWillBeRawPtr<Element> listChild = listChildNode &&
listChildNode->isHTMLElement() ? toHTMLElement(listChildNode) : 0;
+    RefPtrWillBeRawPtr<HTMLElement> listChild = listChildNode &&
listChildNode->isHTMLElement() ? toHTMLElement(listChildNode) : 0;
     Position canonicalPos =
VisiblePosition(insertionPosition).deepEquivalent();
     if (!startBlock
         || !startBlock->nonShadowBoundaryParentNode()

[Inactive, 2014-07-29 23:41:30]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-29 23:42:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/421793002/60001

[commit-bot: I haz the power, 2014-07-30 00:41:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19563)

[commit-bot: I haz the power, 2014-07-30 01:52:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-30 01:52:37]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19569)

[Inactive, 2014-07-30 02:50:32]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-30 02:50:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/421793002/60001

[commit-bot: I haz the power, 2014-07-30 04:01:34]

Change committed as 179195