Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 421723004: Remove support for the old Span classes from source_maps. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove support for the old Span classes from source_maps. This releases source_maps 0.10.0, code_transformers 0.2.0+2, observe 0.11.0+3, and polymer 0.12.0+4. BUG=19930 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38803

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -1004 lines) Patch
M pkg/code_transformers/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/code_transformers/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/observe/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/observe/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/polymer/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/source_maps/lib/builder.dart View 4 chunks +22 lines, -32 lines 0 comments Download
M pkg/source_maps/lib/parser.dart View 1 6 chunks +19 lines, -22 lines 0 comments Download
M pkg/source_maps/lib/printer.dart View 8 chunks +30 lines, -34 lines 0 comments Download
M pkg/source_maps/lib/refactor.dart View 4 chunks +6 lines, -11 lines 0 comments Download
M pkg/source_maps/lib/source_maps.dart View 2 chunks +3 lines, -2 lines 0 comments Download
D pkg/source_maps/lib/span.dart View 1 chunk +0 lines, -404 lines 0 comments Download
A pkg/source_maps/lib/src/source_map_span.dart View 1 chunk +59 lines, -0 lines 0 comments Download
D pkg/source_maps/lib/src/span_wrapper.dart View 1 chunk +0 lines, -85 lines 0 comments Download
M pkg/source_maps/test/builder_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/source_maps/test/common.dart View 3 chunks +23 lines, -21 lines 0 comments Download
M pkg/source_maps/test/end2end_test.dart View 9 chunks +16 lines, -15 lines 0 comments Download
M pkg/source_maps/test/parser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/source_maps/test/printer_test.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M pkg/source_maps/test/refactor_test.dart View 3 chunks +68 lines, -20 lines 0 comments Download
M pkg/source_maps/test/run.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/source_maps/test/span_test.dart View 1 chunk +0 lines, -341 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 3 months ago (2014-07-31 20:34:00 UTC) #1
Siggi Cherem (dart-lang)
lgtm, modulo fixing the type inconsistency (probably just changing Url back to String is all ...
5 years, 3 months ago (2014-07-31 21:01:38 UTC) #2
nweiz
Code review changes
5 years, 3 months ago (2014-07-31 22:01:19 UTC) #3
nweiz
https://codereview.chromium.org/421723004/diff/1/pkg/source_maps/lib/parser.dart File pkg/source_maps/lib/parser.dart (right): https://codereview.chromium.org/421723004/diff/1/pkg/source_maps/lib/parser.dart#newcode189 pkg/source_maps/lib/parser.dart:189: sourceUrl == null ? '' : sourceUrl.toString(), () => ...
5 years, 3 months ago (2014-07-31 22:01:25 UTC) #4
Siggi Cherem (dart-lang)
lgtm
5 years, 3 months ago (2014-07-31 22:02:26 UTC) #5
nweiz
5 years, 3 months ago (2014-07-31 22:04:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r38803 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698