Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 421713002: dm prints out number of matching skp files (Closed)

Created:
6 years, 5 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

dm prints out number of matching skp files Committed: https://skia.googlesource.com/skia/+/a98683bc50a3fe1241396f0ae20e35c7b1133fa9

Patch Set 1 #

Total comments: 2

Patch Set 2 : AnotherPatchSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M dm/DM.cpp View 1 3 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hal.canary
ptal
6 years, 5 months ago (2014-07-25 22:04:48 UTC) #1
hal.canary
6 years, 4 months ago (2014-07-28 13:17:57 UTC) #2
bungeman-skia
lgtm with the ref change. https://codereview.chromium.org/421713002/diff/1/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/421713002/diff/1/dm/DM.cpp#newcode140 dm/DM.cpp:140: SkAutoTDelete<SkStream> stream(SkStream::NewFromFile(skps[i].c_str())); Technically, this ...
6 years, 4 months ago (2014-07-28 14:05:19 UTC) #3
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-07-28 14:10:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/421713002/20001
6 years, 4 months ago (2014-07-28 14:11:03 UTC) #5
commit-bot: I haz the power
Change committed as a98683bc50a3fe1241396f0ae20e35c7b1133fa9
6 years, 4 months ago (2014-07-28 14:21:28 UTC) #6
hal.canary
6 years, 4 months ago (2014-07-28 14:22:09 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/421713002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/421713002/diff/1/dm/DM.cpp#newcode140
dm/DM.cpp:140: SkAutoTDelete<SkStream>
stream(SkStream::NewFromFile(skps[i].c_str()));
On 2014/07/28 14:05:19, bungeman1 wrote:
> Technically, this should be SkAutoTUnref until we get SkStream off of ref
> counting.

Done, but I still think AutoTDelete documents the fact that this object's
lifetime will not extend outside this scope.

Powered by Google App Engine
This is Rietveld 408576698