Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 421703003: test_runner: Rename WebTestThemeEngineMac to MockWebThemeEngineMac. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

test_runner: Rename WebTestThemeEngineMac to MockWebThemeEngineMac. Plus some minor style fixes, mainly clang-format the header. BUG=331299 TEST=content_unittests, content_shell. No functional changes TBR=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285811

Patch Set 1 : #

Patch Set 2 : gyp fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -290 lines) Patch
M content/content_shell.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/TestInterfaces.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/TestInterfaces.cpp View 1 chunk +1 line, -1 line 0 comments Download
D content/shell/renderer/test_runner/WebTestThemeEngineMac.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/shell/renderer/test_runner/WebTestThemeEngineMac.mm View 1 chunk +0 lines, -177 lines 0 comments Download
A + content/shell/renderer/test_runner/mock_web_theme_engine_mac.h View 1 chunk +33 lines, -35 lines 0 comments Download
A + content/shell/renderer/test_runner/mock_web_theme_engine_mac.mm View 5 chunks +16 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
TBRing...
6 years, 4 months ago (2014-07-26 18:39:15 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-07-26 18:39:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/421703003/20001
6 years, 4 months ago (2014-07-26 18:39:56 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-07-26 18:59:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/421703003/40001
6 years, 4 months ago (2014-07-26 18:59:58 UTC) #5
commit-bot: I haz the power
Change committed as 285811
6 years, 4 months ago (2014-07-26 21:24:34 UTC) #6
Dirk Pranke
6 years, 4 months ago (2014-07-29 00:15:27 UTC) #7
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698