Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1785)

Unified Diff: chrome/browser/favicon/favicon_service.cc

Issue 421633002: Modify a favicon DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-add DCHECK but with modification. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_service.cc
diff --git a/chrome/browser/favicon/favicon_service.cc b/chrome/browser/favicon/favicon_service.cc
index a70111e8d02f8fbbcd4401582824fb552929ed3b..aab1e893793378fdf82eef2f3b1957d025eb89a8 100644
--- a/chrome/browser/favicon/favicon_service.cc
+++ b/chrome/browser/favicon/favicon_service.cc
@@ -403,7 +403,7 @@ void FaviconService::RunFaviconRawBitmapCallbackWithBitmapResults(
return;
}
- DCHECK_EQ(1u, favicon_bitmap_results.size());
+ DCHECK_LE(1u, favicon_bitmap_results.size());
stevenjb 2014/07/25 18:45:19 We early exit above if favicon_bitmap_results.empt
stevenjb 2014/07/25 18:47:31 I *think* (it's been a long time) was that the exp
Daniel Nishi 2014/07/25 21:13:37 Yeah, you're right. I've changed it back to the re
favicon_base::FaviconRawBitmapResult bitmap_result =
favicon_bitmap_results[0];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698