Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9720)

Unified Diff: chrome_linux/installer/rpm/build.sh

Issue 42163002: Roll Linux reference build to official build 31.0.1650.34 (trunk r224845, branch r230433) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/reference_builds/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_linux/installer/debian/prerm ('k') | chrome_linux/installer/rpm/chrome.spec.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_linux/installer/rpm/build.sh
===================================================================
--- chrome_linux/installer/rpm/build.sh (revision 230844)
+++ chrome_linux/installer/rpm/build.sh (working copy)
@@ -34,18 +34,31 @@
# Put the package contents in the staging area.
stage_install_rpm() {
- # Trunk packages need to install to a custom path and with custom filenames
- # (e.g. not /usr/bin/google-chrome) so they don't conflict with release
- # channel packages.
- if [ "$CHANNEL" = "trunk" ] || [ "$CHANNEL" = "asan" ]; then
- local PACKAGE="${PACKAGE}-${CHANNEL}"
- local INSTALLDIR="${INSTALLDIR}-${CHANNEL}"
+ # TODO(phajdan.jr): Deduplicate this and debian/build.sh .
+ # For now duplication is going to help us avoid merge conflicts
+ # as changes are frequently merged to older branches related to SxS effort.
+ if [ "$CHANNEL" != "stable" ]; then
# This would ideally be compiled into the app, but that's a bit too
# intrusive of a change for these limited use channels, so we'll just hack
# it into the wrapper script. The user can still override since it seems to
# work to specify --user-data-dir multiple times on the command line, with
# the last occurrence winning.
- local DEFAULT_FLAGS="--user-data-dir=\"\${HOME}/.config/${PACKAGE}\""
+ local SXS_USER_DATA_DIR="\${XDG_CONFIG_HOME:-\${HOME}/.config}/${PACKAGE}-${CHANNEL}"
+ local DEFAULT_FLAGS="--user-data-dir=\"${SXS_USER_DATA_DIR}\""
+
+ # Avoid file collisions between channels.
+ # TODO(phajdan.jr): Do that for all packages for SxS,
+ # http://crbug.com/38598 .
+ # We can't do this for now for all packages because of
+ # http://crbug.com/295103 , and ultimately http://crbug.com/22703 .
+ # Also see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/DBEqOORaRiw/pE0bNI6h0kcJ .
+ if [ "$CHANNEL" = "trunk" ] || [ "$CHANNEL" = "asan" ]; then
+ local PACKAGE="${PACKAGE}-${CHANNEL}"
+ local INSTALLDIR="${INSTALLDIR}-${CHANNEL}"
+ fi
+
+ # Make it possible to distinguish between menu entries
+ # for different channels.
local MENUNAME="${MENUNAME} (${CHANNEL})"
fi
prep_staging_rpm
@@ -276,6 +289,7 @@
REPOCONFIG="http://dl.google.com/linux/${PACKAGE#google-}/rpm/stable"
verify_channel
+export USR_BIN_SYMLINK_NAME="${PACKAGE}-${CHANNEL}"
# Make everything happen in the OUTPUTDIR.
cd "${OUTPUTDIR}"
« no previous file with comments | « chrome_linux/installer/debian/prerm ('k') | chrome_linux/installer/rpm/chrome.spec.template » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698