Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 421603002: Note creation of AudioContext when DEBUG_AUDIONODE_REFERENCES is set. (Closed)

Created:
6 years, 5 months ago by Raymond Toy
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Note creation of AudioContext when DEBUG_AUDIONODE_REFERENCES is set. When DEBUG_AUDIONODE_REFERENCES is set, a message for the destruction of an AudioContext is printed, but there's no matching message for the creation of an AudioContext. Add one to make it symmetric and so we can see how many contexts are created. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178958

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/modules/webaudio/AudioContext.cpp View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Raymond Toy
PTAL at this trivial change that has no effect on normal usage. It's only for ...
6 years, 5 months ago (2014-07-25 17:04:28 UTC) #1
Ken Russell (switch to Gerrit)
LGTM, but: https://codereview.chromium.org/421603002/diff/1/Source/modules/webaudio/AudioContext.cpp File Source/modules/webaudio/AudioContext.cpp (right): https://codereview.chromium.org/421603002/diff/1/Source/modules/webaudio/AudioContext.cpp#newcode129 Source/modules/webaudio/AudioContext.cpp:129: fprintf(stderr, "%p: AudioContext::AudioContext() #%u\n", this, AudioContext::s_hardwareContextCount); Why ...
6 years, 5 months ago (2014-07-25 18:28:56 UTC) #2
Raymond Toy
On 2014/07/25 18:28:56, Ken Russell wrote: > LGTM, but: > > https://codereview.chromium.org/421603002/diff/1/Source/modules/webaudio/AudioContext.cpp > File Source/modules/webaudio/AudioContext.cpp ...
6 years, 5 months ago (2014-07-25 18:41:28 UTC) #3
Ken Russell (switch to Gerrit)
On 2014/07/25 18:41:28, Raymond Toy wrote: > On 2014/07/25 18:28:56, Ken Russell wrote: > > ...
6 years, 5 months ago (2014-07-25 19:41:56 UTC) #4
Raymond Toy
On 2014/07/25 19:41:56, Ken Russell wrote: > On 2014/07/25 18:41:28, Raymond Toy wrote: > > ...
6 years, 5 months ago (2014-07-25 20:14:20 UTC) #5
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
6 years, 5 months ago (2014-07-25 20:14:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@chromium.org/421603002/1
6 years, 5 months ago (2014-07-25 20:15:06 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 21:18:09 UTC) #8
Message was sent while issue was closed.
Change committed as 178958

Powered by Google App Engine
This is Rietveld 408576698