Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 42158: Get rid of the gears in renderer process code. This allows me to do some cle... (Closed)

Created:
11 years, 9 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Get rid of the gears in renderer process code. This allows me to do some cleanup in how resource dispatching happens in a future cl. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11601

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -828 lines) Patch
M chrome/browser/chrome_plugin_host.cc View 1 1 chunk +15 lines, -30 lines 1 comment Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/sandbox_policy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sandbox_policy.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/plugin/webplugin_proxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/renderer/chrome_plugin_host.h View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/renderer/chrome_plugin_host.cc View 1 chunk +0 lines, -651 lines 0 comments Download
M chrome/renderer/render_process.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/renderer/render_process.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/renderer/render_thread.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/render_thread.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/renderer/render_view.cc View 5 chunks +1 line, -25 lines 0 comments Download
M chrome/renderer/renderer.scons View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/renderer/renderer.vcproj View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
11 years, 9 months ago (2009-03-12 23:46:51 UTC) #1
Matt Perry
Thanks for cleaning this up. Two small changes, then LGTM: - gyp project change? - ...
11 years, 9 months ago (2009-03-12 23:52:16 UTC) #2
jam
updated gyp http://codereview.chromium.org/42158/diff/1/2 File chrome/browser/chrome_plugin_host.cc (right): http://codereview.chromium.org/42158/diff/1/2#newcode691 Line 691: return CPERR_FAILURE; On 2009/03/12 23:52:17, Matt ...
11 years, 9 months ago (2009-03-13 00:16:29 UTC) #3
Matt Perry
http://codereview.chromium.org/42158/diff/1002/38 File chrome/browser/chrome_plugin_host.cc (right): http://codereview.chromium.org/42158/diff/1002/38#newcode693 Line 693: service->FindOrStartPluginProcess(plugin->filename(), std::string()); indent this too please
11 years, 9 months ago (2009-03-13 00:38:15 UTC) #4
Matt Perry
11 years, 9 months ago (2009-03-13 00:38:24 UTC) #5
LGTm

Powered by Google App Engine
This is Rietveld 408576698