Issue 421573002: DevTools: NetworkPanel: get rid of getters/setters.

Issue 421573002: DevTools: NetworkPanel: get rid of getters/setters. (Closed)

Created:
6 years, 5 months ago by eustas

Modified:
6 years, 5 months ago

Reviewers:
vsevik, aandrey

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: NetworkPanel: get rid of getters/setters. Only one getter left. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178942

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -28 lines)			Patch
	M	Source/devtools/front_end/network/NetworkPanel.js	View	1	16 chunks	+48 lines, -28 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

aandrey

lgtm https://codereview.chromium.org/421573002/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/421573002/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode195 Source/devtools/front_end/network/NetworkPanel.js:195: if (!this.largeRows()) nit: i'd prefer useLargeRows() which IMHO ...

6 years, 5 months ago (2014-07-25 16:11:01 UTC) #2

eustas

https://codereview.chromium.org/421573002/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/421573002/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode195 Source/devtools/front_end/network/NetworkPanel.js:195: if (!this.largeRows()) On 2014/07/25 16:11:01, aandrey wrote: > nit: ...

6 years, 5 months ago (2014-07-25 16:24:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/421573002/20001

6 years, 5 months ago (2014-07-25 16:25:17 UTC) #5

Message was sent while issue was closed.

Change committed as 178942

Expand Messages | Collapse Messages