[Password Manager] Add experiment controlling sync credential saving behavior

[Password Manager] Add experiment controlling sync credential saving behavior

I also updated ProvisionalSaveFailure in histograms.xml, which was an oversight from a previous cl.

BUG=386402
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288162

[Ilya Sherman, 2014-07-30 23:03:11]

https://codereview.chromium.org/421563003/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/421563003/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager.cc:57: bool
ShouldNotSaveSyncCredential() {
nit: "ShouldNotFoo()" is a little hard to read in context -- it makes me have to
invert a boolean concept in my head when reading code.  Perhaps
"ShouldDropSyncCredential" or something like that?

https://codereview.chromium.org/421563003/diff/1/components/password_manager/...
File components/password_manager/core/common/password_manager_switches.cc
(right):

https://codereview.chromium.org/421563003/diff/1/components/password_manager/...
components/password_manager/core/common/password_manager_switches.cc:26:
"enable-save-sync-credential";
Please add your new switches to about:flags (as a tri-state switch).

[Garrett Casto, 2014-07-31 00:18:50]

https://codereview.chromium.org/421563003/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/421563003/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager.cc:57: bool
ShouldNotSaveSyncCredential() {
On 2014/07/30 23:03:10, Ilya Sherman wrote:
> nit: "ShouldNotFoo()" is a little hard to read in context -- it makes me have
to
> invert a boolean concept in my head when reading code.  Perhaps
> "ShouldDropSyncCredential" or something like that?

I like it. Done.

https://codereview.chromium.org/421563003/diff/1/components/password_manager/...
File components/password_manager/core/common/password_manager_switches.cc
(right):

https://codereview.chromium.org/421563003/diff/1/components/password_manager/...
components/password_manager/core/common/password_manager_switches.cc:26:
"enable-save-sync-credential";
On 2014/07/30 23:03:11, Ilya Sherman wrote:
> Please add your new switches to about:flags (as a tri-state switch).

I didn't do this at first because I wasn't sure that we actually wanted to
really expose this as a user choice. However knowing if users actively change
this flag might factor into our decision, so I made the change.

[Ilya Sherman, 2014-07-31 00:42:03]

LGTM % nits.  Thanks.

https://codereview.chromium.org/421563003/diff/20001/components/password_mana...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/421563003/diff/20001/components/password_mana...
components/password_manager/core/browser/password_manager.cc:60:
"PasswordManagerDropSyncCredential");
I take it you haven't yet set up a server-side configuration for this trial?

https://codereview.chromium.org/421563003/diff/20001/components/password_mana...
components/password_manager/core/browser/password_manager.cc:60:
"PasswordManagerDropSyncCredential");
nit: Doesn't look like this line needs to wrap.

https://codereview.chromium.org/421563003/diff/20001/components/password_mana...
File components/password_manager/core/common/password_manager_switches.h
(right):

https://codereview.chromium.org/421563003/diff/20001/components/password_mana...
components/password_manager/core/common/password_manager_switches.h:19: extern
const char kEnableAutomaticPasswordSaving[];
nit: According to the comment above, these lines should be sorted
alphabetically.

[Garrett Casto, 2014-08-06 21:43:47]

https://codereview.chromium.org/421563003/diff/20001/components/password_mana...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/421563003/diff/20001/components/password_mana...
components/password_manager/core/browser/password_manager.cc:60:
"PasswordManagerDropSyncCredential");
On 2014/07/31 00:42:03, Ilya Sherman wrote:
> I take it you haven't yet set up a server-side configuration for this trial?

No, not yet.

https://codereview.chromium.org/421563003/diff/20001/components/password_mana...
components/password_manager/core/browser/password_manager.cc:60:
"PasswordManagerDropSyncCredential");
On 2014/07/31 00:42:03, Ilya Sherman wrote:
> nit: Doesn't look like this line needs to wrap.

Done.

https://codereview.chromium.org/421563003/diff/20001/components/password_mana...
File components/password_manager/core/common/password_manager_switches.h
(right):

https://codereview.chromium.org/421563003/diff/20001/components/password_mana...
components/password_manager/core/common/password_manager_switches.h:19: extern
const char kEnableAutomaticPasswordSaving[];
On 2014/07/31 00:42:03, Ilya Sherman wrote:
> nit: According to the comment above, these lines should be sorted
> alphabetically.

Done.

[Garrett Casto, 2014-08-06 21:46:49]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-08-06 21:48:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gcasto@chromium.org/421563003/40001

[commit-bot: I haz the power, 2014-08-06 23:37:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/38225)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/43433)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-06 23:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 23:41:36]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/38289)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[Garrett Casto, 2014-08-07 17:48:07]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-08-07 17:56:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gcasto@chromium.org/421563003/60001

[commit-bot: I haz the power, 2014-08-07 19:38:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-07 23:38:53]

Change committed as 288162