Issue 421563002: Add vertex color support to distance field text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 421563002: Add vertex color support to distance field text. (Closed)

Created:
6 years, 5 months ago by jvanverth1

Modified:
6 years, 5 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@text-refactor-7-25

Project:
skia

Visibility:
Public.

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -35 lines)			Patch
	M	src/gpu/GrDistanceFieldTextContext.cpp	View	1	10 chunks	+68 lines, -35 lines	0 comments	Download

Total messages: 6 (0 generated)

bsalomon

lgtm. do you think there's a way to share more code between the two clases?

6 years, 5 months ago (2014-07-25 16:16:01 UTC) #2

jvanverth1

On 2014/07/25 16:16:01, bsalomon wrote: > lgtm. do you think there's a way to share ...

6 years, 5 months ago (2014-07-25 18:49:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/421563002/20001

6 years, 5 months ago (2014-07-26 01:52:23 UTC) #5

commit-bot: I haz the power

6 years, 5 months ago (2014-07-26 02:03:40 UTC) #6

Message was sent while issue was closed.

Change committed as feceba5e2d4504adbf4bca963c175fcc60be1d58