Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 421553002: Teach releases script to read bleeding_edge tags. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Teach releases script to read bleeding_edge tags. The command 'git svn log' does unfortunately not provide the tag-revision relation. We therefore use 'svn log' to retrieve it from the remote repository. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22646

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -17 lines) Patch
M tools/push-to-trunk/releases.py View 4 chunks +44 lines, -16 lines 1 comment Download
M tools/push-to-trunk/test_scripts.py View 3 chunks +47 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/421553002/diff/80001/tools/push-to-trunk/releases.py File tools/push-to-trunk/releases.py (left): https://codereview.chromium.org/421553002/diff/80001/tools/push-to-trunk/releases.py#oldcode156 tools/push-to-trunk/releases.py:156: return { Small refactoring. I move the dict ...
6 years, 4 months ago (2014-07-28 12:56:35 UTC) #1
Jarin
lgtm
6 years, 4 months ago (2014-07-28 13:36:59 UTC) #2
Michael Achenbach
6 years, 4 months ago (2014-07-28 13:49:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22646 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698