Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1799)

Unified Diff: pkg/polymer/lib/src/build/common.dart

Issue 421503004: Switch transformers over to source_span (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update barback deps. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/src/build/common.dart
diff --git a/pkg/polymer/lib/src/build/common.dart b/pkg/polymer/lib/src/build/common.dart
index 03c05bf6d56cd48b9b02f72c88c30e6ebb8015c8..dd70a223d53353ea93b2109776fb40986bfbde2a 100644
--- a/pkg/polymer/lib/src/build/common.dart
+++ b/pkg/polymer/lib/src/build/common.dart
@@ -16,7 +16,6 @@ import 'package:html5lib/dom.dart' show Document;
import 'package:html5lib/parser.dart' show HtmlParser;
import 'package:path/path.dart' as path;
import 'package:observe/transformer.dart' show ObservableTransformer;
-import 'package:source_maps/span.dart' show Span;
Siggi Cherem (dart-lang) 2014/07/29 23:41:37 we probably need the equivalent import, otherwise
nweiz 2014/07/29 23:48:39 I don't think the analyzer looks at references in
Siggi Cherem (dart-lang) 2014/07/30 00:00:06 mmm - I think I got confused because it will not c
nweiz 2014/07/30 00:25:53 Done.
const _ignoredErrors = const [
'unexpected-dash-after-double-dash-in-comment',
@@ -125,7 +124,7 @@ abstract class PolymerTransformer {
String toString() => 'polymer ($runtimeType)';
}
-/// Gets the appropriate URL to use in a [Span] to produce messages
+/// Gets the appropriate URL to use in a [SourceSpan] to produce messages
/// (e.g. warnings) for users. This will attempt to format the URL in the most
/// useful way:
///

Powered by Google App Engine
This is Rietveld 408576698