Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: pkg/third_party/html5lib/lib/src/inputstream.dart

Issue 421503004: Switch transformers over to source_span (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/third_party/html5lib/lib/parser.dart ('k') | pkg/third_party/html5lib/lib/src/token.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/third_party/html5lib/lib/src/inputstream.dart
diff --git a/pkg/third_party/html5lib/lib/src/inputstream.dart b/pkg/third_party/html5lib/lib/src/inputstream.dart
index 5686abf755598336e8dc4d2898ccdbebc0ff1013..231fed0c5c259d4cecd040288665e7b2bb39c4b3 100644
--- a/pkg/third_party/html5lib/lib/src/inputstream.dart
+++ b/pkg/third_party/html5lib/lib/src/inputstream.dart
@@ -2,7 +2,7 @@ library inputstream;
import 'dart:collection';
import 'package:utf/utf.dart';
-import 'package:source_maps/span.dart' show SourceFile;
+import 'package:source_span/source_span.dart';
import 'char_encodings.dart';
import 'constants.dart';
import 'utils.dart';
@@ -135,8 +135,9 @@ class HtmlInputStream {
// Free decoded characters if they aren't needed anymore.
if (_rawBytes != null) _rawChars = null;
- fileInfo = new SourceFile(sourceUrl, _lineStarts,
- generateSpans ? _chars : null);
+ // TODO(sigmund): Don't parse the file at all if spans aren't being
+ // generated.
+ fileInfo = new SourceFile.decoded(_chars, url: sourceUrl);
}
« no previous file with comments | « pkg/third_party/html5lib/lib/parser.dart ('k') | pkg/third_party/html5lib/lib/src/token.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698