Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: pkg/polymer/lib/src/build/script_compactor.dart

Issue 421503004: Switch transformers over to source_span (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/lib/src/build/linter.dart ('k') | pkg/polymer/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/build/script_compactor.dart
diff --git a/pkg/polymer/lib/src/build/script_compactor.dart b/pkg/polymer/lib/src/build/script_compactor.dart
index 1c46f1d1abe1a2aa98ccf684f08e448cd44a413c..bc09c68417d187ad2d04aa21d81627a3c4926bfa 100644
--- a/pkg/polymer/lib/src/build/script_compactor.dart
+++ b/pkg/polymer/lib/src/build/script_compactor.dart
@@ -16,7 +16,7 @@ import 'package:analyzer/src/generated/element.dart' hide Element;
import 'package:analyzer/src/generated/element.dart' as analyzer show Element;
import 'package:barback/barback.dart';
import 'package:path/path.dart' as path;
-import 'package:source_maps/span.dart' show SourceFile, Span;
+import 'package:source_span/source_span.dart';
import 'package:smoke/codegen/generator.dart';
import 'package:smoke/codegen/recorder.dart';
import 'package:code_transformers/resolver.dart';
@@ -502,8 +502,6 @@ class _CustomTagInitializer implements _Initializer {
"() => Polymer.register('$tagName', $prefix.$typeName)";
}
-_getSpan(SourceFile file, AstNode node) => file.span(node.offset, node.end);
-
const MAIN_HEADER = """
library app_bootstrap;
@@ -595,7 +593,7 @@ class _HtmlExtractor extends TreeVisitor {
}
void _addExpression(String stringExpression, bool inEvent, bool isTwoWay,
- Span span) {
+ SourceSpan span) {
if (inEvent) {
if (stringExpression.startsWith('@')) {
@@ -623,7 +621,7 @@ class _SubExpressionVisitor extends pe.RecursiveVisitor {
final SmokeCodeGenerator generator;
final TransformLogger logger;
bool _includeSetter;
- Span _currentSpan;
+ SourceSpan _currentSpan;
_SubExpressionVisitor(this.generator, this.logger);
« no previous file with comments | « pkg/polymer/lib/src/build/linter.dart ('k') | pkg/polymer/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698