Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: pkg/polymer/lib/src/build/common.dart

Issue 421503004: Switch transformers over to source_span (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/observe/pubspec.yaml ('k') | pkg/polymer/lib/src/build/import_inliner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/build/common.dart
diff --git a/pkg/polymer/lib/src/build/common.dart b/pkg/polymer/lib/src/build/common.dart
index 03c05bf6d56cd48b9b02f72c88c30e6ebb8015c8..ac74e89d13c1615c98596505d8efed5a96c3e56d 100644
--- a/pkg/polymer/lib/src/build/common.dart
+++ b/pkg/polymer/lib/src/build/common.dart
@@ -16,7 +16,6 @@ import 'package:html5lib/dom.dart' show Document;
import 'package:html5lib/parser.dart' show HtmlParser;
import 'package:path/path.dart' as path;
import 'package:observe/transformer.dart' show ObservableTransformer;
-import 'package:source_maps/span.dart' show Span;
const _ignoredErrors = const [
'unexpected-dash-after-double-dash-in-comment',
@@ -125,9 +124,9 @@ abstract class PolymerTransformer {
String toString() => 'polymer ($runtimeType)';
}
-/// Gets the appropriate URL to use in a [Span] to produce messages
-/// (e.g. warnings) for users. This will attempt to format the URL in the most
-/// useful way:
+/// Gets the appropriate URL to use in a span to produce messages (e.g.
+/// warnings) for users. This will attempt to format the URL in the most useful
+/// way:
///
/// - If the asset is within the primary package, then use the [id.path],
/// the user will know it is a file from their own code.
« no previous file with comments | « pkg/observe/pubspec.yaml ('k') | pkg/polymer/lib/src/build/import_inliner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698