Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3139)

Unified Diff: pkg/code_transformers/lib/assets.dart

Issue 421503004: Switch transformers over to source_span (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/code_transformers/CHANGELOG.md ('k') | pkg/code_transformers/lib/src/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/code_transformers/lib/assets.dart
diff --git a/pkg/code_transformers/lib/assets.dart b/pkg/code_transformers/lib/assets.dart
index 9a76c876651476da3bd25a150d48a75575f0941c..60cc75dbebc3d0ca0db03af63be6854ca0921b62 100644
--- a/pkg/code_transformers/lib/assets.dart
+++ b/pkg/code_transformers/lib/assets.dart
@@ -9,7 +9,7 @@ import 'dart:math' show min, max;
import 'package:barback/barback.dart';
import 'package:path/path.dart' as path;
-import 'package:source_maps/span.dart' show Span;
+import 'package:source_span/source_span.dart';
/// Create an [AssetId] for a [url] seen in the [source] asset.
///
@@ -25,7 +25,7 @@ import 'package:source_maps/span.dart' show Span;
/// absolute.
// TODO(sigmund): delete once this is part of barback (dartbug.com/12610)
AssetId uriToAssetId(AssetId source, String url, TransformLogger logger,
- Span span, {bool errorOnAbsolute: true}) {
+ SourceSpan span, {bool errorOnAbsolute: true}) {
if (url == null || url == '') return null;
var uri = Uri.parse(url);
var urlBuilder = path.url;
@@ -94,7 +94,7 @@ AssetId uriToAssetId(AssetId source, String url, TransformLogger logger,
}
AssetId _extractOtherPackageId(int index, List segments,
- TransformLogger logger, Span span) {
+ TransformLogger logger, SourceSpan span) {
if (index >= segments.length) return null;
var prefix = segments[index];
if (prefix != 'packages' && prefix != 'assets') return null;
« no previous file with comments | « pkg/code_transformers/CHANGELOG.md ('k') | pkg/code_transformers/lib/src/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698