Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 421503002: Re-introduce forward declaration of WebCompositorAnimation (Closed)

Created:
6 years, 5 months ago by samli
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Re-introduce forward declaration of WebCompositorAnimation This change reverts necessary changes in patch http://crrev.com/413983002 which was needed to successfully rename WebAnimation to WebCompositorAnimation. This is the patch 4 of 4 and follows on from http://crrev.com/412123002 BUG=396358 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290729

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M cc/blink/web_animation_impl.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M cc/blink/web_animation_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/blink/web_to_cc_animation_delegate_adapter.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M cc/blink/web_to_cc_animation_delegate_adapter.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
samli
6 years, 5 months ago (2014-07-25 04:57:41 UTC) #1
Ian Vollick
On 2014/07/25 04:57:41, samli wrote: lg2m
6 years, 5 months ago (2014-07-25 17:14:49 UTC) #2
samli
+enne Awaiting OWNERs approval
6 years, 4 months ago (2014-08-19 03:31:00 UTC) #3
enne (OOO)
vollick is an OWNER of cc/blink. ;) rslgtm
6 years, 4 months ago (2014-08-19 17:26:10 UTC) #4
samli
The CQ bit was checked by samli@chromium.org
6 years, 4 months ago (2014-08-20 01:02:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samli@chromium.org/421503002/20001
6 years, 4 months ago (2014-08-20 01:02:41 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 02:04:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290729

Powered by Google App Engine
This is Rietveld 408576698