Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 421483003: Parameterize TaskRunner used by ui::Compositor (Closed)

Created:
6 years, 5 months ago by ccameron
Modified:
6 years, 5 months ago
CC:
chromium-reviews, ben+aura_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, Ian Vollick, jam, penghuang+watch_chromium.org, sadrul, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, cc-bugs_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@task_runner
Project:
chromium
Visibility:
Public.

Description

Parameterize TaskRunner used by ui::Compositor This has no functional change, but prepares the field for allowing the Mac to use a different TaskRunner which will allow pumping during resize. BUG=392031 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285694

Patch Set 1 #

Patch Set 2 : Remove remanants of testing #

Patch Set 3 : Add missing includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M content/browser/compositor/browser_compositor_view_private_mac.mm View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/compositor/software_output_device_ozone_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/aura/window_tree_host.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M ui/compositor/compositor.h View 3 chunks +4 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_ozone.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_win.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_x11.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
ccameron
This doesn't actually do anything, but it prepares the field for the next change which ...
6 years, 5 months ago (2014-07-25 01:22:30 UTC) #1
piman
lgtm
6 years, 5 months ago (2014-07-25 01:59:07 UTC) #2
ccameron
Adding ben to stamp ui/aura
6 years, 5 months ago (2014-07-25 16:58:46 UTC) #3
ccameron
Trying sky for OWNER stamp for ui/ (no substantial changes).
6 years, 5 months ago (2014-07-25 19:46:34 UTC) #4
sky
I assume you mean ui/aura - LGTM
6 years, 5 months ago (2014-07-25 20:24:04 UTC) #5
ccameron
yes -- Thanks!
6 years, 5 months ago (2014-07-25 20:24:49 UTC) #6
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 5 months ago (2014-07-25 20:24:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/421483003/40001
6 years, 5 months ago (2014-07-25 20:27:17 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 21:54:21 UTC) #9
Message was sent while issue was closed. 
Change committed as 285694

Powered by Google App Engine
This is Rietveld 408576698