Source/core/rendering/RenderText.cpp - Issue 421463002: Have BidiRunList destructor delete runs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderText.cpp

Issue 421463002: Have BidiRunList destructor delete runs (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: removed SVGTextMetricsCalculator destructor Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderText.cpp

diff --git a/Source/core/rendering/RenderText.cpp b/Source/core/rendering/RenderText.cpp

index 846099469db15315aa31701997d8097c4f86a640..91a455a548ef65746af31fd76179a770f7a7df11 100644

--- a/Source/core/rendering/RenderText.cpp

+++ b/Source/core/rendering/RenderText.cpp

@@ -1112,8 +1112,6 @@ void RenderText::computePreferredLogicalWidths(float leadWidth, HashSet<const Si

lastWordBoundary++;

}

- if (run)

- bidiRuns.deleteRuns();

if (firstGlyphLeftOverflow > 0)

glyphOverflow.left = firstGlyphLeftOverflow;