Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: Source/platform/text/BidiResolverTest.cpp

Issue 421463002: Have BidiRunList destructor delete runs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 for (size_t i = 0; i < expectedLevels.size(); i++) { 233 for (size_t i = 0; i < expectedLevels.size(); i++) {
234 // level == -1 means the level should be ignored. 234 // level == -1 means the level should be ignored.
235 if (expectedLevels[i] == actualLevels[i] || expectedLevels[i] == -1) 235 if (expectedLevels[i] == actualLevels[i] || expectedLevels[i] == -1)
236 continue; 236 continue;
237 237
238 printf("LEVELS %s%s\n", diffString(actualLevels, expectedLevels).c_s tr(), errorContext.str().c_str()); 238 printf("LEVELS %s%s\n", diffString(actualLevels, expectedLevels).c_s tr(), errorContext.str().c_str());
239 m_levelFailures++; 239 m_levelFailures++;
240 break; 240 break;
241 } 241 }
242 } 242 }
243 runs.deleteRuns();
244 } 243 }
245 244
246 245
247 TEST(BidiResolver, BidiTest_txt) 246 TEST(BidiResolver, BidiTest_txt)
248 { 247 {
249 BidiTestRunner runner; 248 BidiTestRunner runner;
250 // Blink's Unicode Bidi Algorithm (UBA) doesn't yet support the 249 // Blink's Unicode Bidi Algorithm (UBA) doesn't yet support the
251 // new isolate directives from Unicode 6.3: 250 // new isolate directives from Unicode 6.3:
252 // http://www.unicode.org/reports/tr9/#Explicit_Directional_Isolates 251 // http://www.unicode.org/reports/tr9/#Explicit_Directional_Isolates
253 runner.skipTestsWith(0x2066); // LRI 252 runner.skipTestsWith(0x2066); // LRI
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 // The unittest harness only pays attention to GTest output, so we verify 284 // The unittest harness only pays attention to GTest output, so we verify
286 // that the tests behaved as expected: 285 // that the tests behaved as expected:
287 EXPECT_EQ(352098u, runner.m_testsRun); 286 EXPECT_EQ(352098u, runner.m_testsRun);
288 EXPECT_EQ(418143u, runner.m_testsSkipped); 287 EXPECT_EQ(418143u, runner.m_testsSkipped);
289 EXPECT_EQ(0u, runner.m_ignoredCharFailures); 288 EXPECT_EQ(0u, runner.m_ignoredCharFailures);
290 EXPECT_EQ(44882u, runner.m_levelFailures); 289 EXPECT_EQ(44882u, runner.m_levelFailures);
291 EXPECT_EQ(19151u, runner.m_orderFailures); 290 EXPECT_EQ(19151u, runner.m_orderFailures);
292 } 291 }
293 292
294 } 293 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698