Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: test/toplevel-dir/gyptest-toplevel-dir.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase onto origin/master Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/toplevel-dir/gyptest-toplevel-dir.py
diff --git a/test/toplevel-dir/gyptest-toplevel-dir.py b/test/toplevel-dir/gyptest-toplevel-dir.py
index 4daa6b2c11936226080e581d536fe1cfd1b3f811..99405b41f26c6fddb341cdac50e3401e36f954e4 100755
--- a/test/toplevel-dir/gyptest-toplevel-dir.py
+++ b/test/toplevel-dir/gyptest-toplevel-dir.py
@@ -14,6 +14,8 @@ import TestGyp
import errno
test = TestGyp.TestGyp(formats=['ninja', 'make'])
+if test.format == 'xcode-ninja':
sdefresne 2014/09/02 15:13:06 Please document.
Tobias 2014/10/02 18:19:20 This test actually was working by chance only. The
+ test.skip_test()
# We want our Makefile to be one dir up from main.gyp.
test.run_gyp('main.gyp', '--toplevel-dir=..', chdir='src/sub1')

Powered by Google App Engine
This is Rietveld 408576698