Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: test/mac/gyptest-global-settings.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase onto origin/master Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mac/gyptest-global-settings.py
diff --git a/test/mac/gyptest-global-settings.py b/test/mac/gyptest-global-settings.py
index 648d32cded99df9ae66acc84cf069dc733003de3..5dd2824e718379b07d9dcd1e084a16e36069945b 100644
--- a/test/mac/gyptest-global-settings.py
+++ b/test/mac/gyptest-global-settings.py
@@ -15,6 +15,11 @@ import sys
if sys.platform == 'darwin':
test = TestGyp.TestGyp(formats=['ninja', 'make', 'xcode'])
+
+ # The ninja generator ignores SYMROOT, while the xcode generator doesn't.
sdefresne 2014/09/02 15:13:05 Same here.
Tobias 2014/10/02 18:19:19 Done.
+ if test.format == 'xcode-ninja':
+ test.skip_test()
+
test.run_gyp('src/dir2/dir2.gyp', chdir='global-settings', depth='src')
# run_gyp shouldn't throw.

Powered by Google App Engine
This is Rietveld 408576698