Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: test/gyp-defines/gyptest-multiple-values.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase onto origin/master Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/gyp-defines/gyptest-multiple-values.py
diff --git a/test/gyp-defines/gyptest-multiple-values.py b/test/gyp-defines/gyptest-multiple-values.py
index 7c38257582be57b59b2f6f1525e36d6dbf799c59..e0a149a0f093a788e6fad91fd5d6e2014402cc03 100644
--- a/test/gyp-defines/gyptest-multiple-values.py
+++ b/test/gyp-defines/gyptest-multiple-values.py
@@ -15,14 +15,18 @@ import TestGyp
test = TestGyp.TestGyp()
os.environ['GYP_DEFINES'] = 'key=value1 key=value2 key=value3'
-test.run_gyp('defines.gyp')
+test.run_gyp('defines.gyp',
+ '-G', 'xcode_ninja_target_pattern=^test_target$')
+
test.build('defines.gyp')
test.must_contain('action.txt', 'value3')
# The last occurrence of a repeated set should take precedence over other
# values.
os.environ['GYP_DEFINES'] = 'key=repeated_value key=value1 key=repeated_value'
-test.run_gyp('defines.gyp')
+test.run_gyp('defines.gyp',
+ '-G', 'xcode_ninja_target_pattern=^test_target$')
+
if test.format == 'msvs' and not test.uses_msbuild:
# msvs versions before 2010 don't detect build rule changes not reflected
# in file system timestamps. Rebuild to see differences.

Powered by Google App Engine
This is Rietveld 408576698