Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/generator-output/gyptest-symlink.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase onto origin/master Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/generator-output/gyptest-subdir2-deep.py ('K') | « test/generator-output/gyptest-subdir2-deep.py ('k') | test/generator-output/gyptest-top-all.py » ('j') | test/generator-output/gyptest-top-all.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/generator-output/gyptest-symlink.py
diff --git a/test/generator-output/gyptest-symlink.py b/test/generator-output/gyptest-symlink.py
index 7390fcd37f15d0434618ea287fe608c643e5293a..e0a484a1ab6a50fa5d54c3bf28fad51647849590 100755
--- a/test/generator-output/gyptest-symlink.py
+++ b/test/generator-output/gyptest-symlink.py
@@ -18,6 +18,10 @@ test = TestGyp.TestGyp(formats=['!android'])
if not hasattr(os, 'symlink'):
test.skip_test('Missing os.symlink -- skipping test.\n')
+# Bug: xcode-ninja doesn't respect --generator-output
sdefresne 2014/09/02 15:13:05 Same here.
+if test.format == 'xcode-ninja':
+ test.skip_test()
+
test.writable(test.workpath('src'), False)
test.writable(test.workpath('src/subdir2/deeper/build'), True)
« test/generator-output/gyptest-subdir2-deep.py ('K') | « test/generator-output/gyptest-subdir2-deep.py ('k') | test/generator-output/gyptest-top-all.py » ('j') | test/generator-output/gyptest-top-all.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698