Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: test/build-option/gyptest-build.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase onto origin/master Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/build-option/gyptest-build.py
diff --git a/test/build-option/gyptest-build.py b/test/build-option/gyptest-build.py
index 6dfadb293745cdb9c349d436d58e67038efdf9c8..d3c211d510a5f94e5055e2992f36b5cea55794ca 100755
--- a/test/build-option/gyptest-build.py
+++ b/test/build-option/gyptest-build.py
@@ -19,6 +19,10 @@ if test.format == 'android':
# https://code.google.com/p/gyp/issues/detail?id=436
test.skip_test(message='Test fails on android. Fix and reenable.\n')
+if test.format == 'xcode-ninja':
+ # The xcode-ninja generator doesn't support --build
sdefresne 2014/09/02 15:13:05 Is this a bug or by design? If it is a bug, I thin
Tobias 2014/10/02 18:19:18 I'm not sure. I've added a link to https://code.go
+ test.skip_test()
+
test.run_gyp('hello.gyp', '--build=Default')
test.run_built_executable('hello', stdout="Hello, world!\n")

Powered by Google App Engine
This is Rietveld 408576698