test/mac/gyptest-strip.py - Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mac/gyptest-strip.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase onto origin/master Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mac/gyptest-strip.py

diff --git a/test/mac/gyptest-strip.py b/test/mac/gyptest-strip.py

index e2c06c13589eb8359b9828dbadcdef192040572d..a729521e18459b5bcad40c81a18794d040aa2b34 100755

--- a/test/mac/gyptest-strip.py

+++ b/test/mac/gyptest-strip.py

@@ -41,7 +41,8 @@ if sys.platform == 'darwin':

# with Xcode 5.0 or higher, take this additional symbol into consideration

# for unstripped builds (it is stripped by all strip commands).

expected_extra_symbol_count = 0

- if test.format == 'ninja' and TestMac.Xcode.Version() >= '0500':

+ if test.format in ['ninja', 'xcode-ninja'] \

+ and TestMac.Xcode.Version() >= '0500':

expected_extra_symbol_count = 1

# The actual numbers here are not interesting, they just need to be the same

« no previous file with comments | « test/mac/gyptest-rpath.py ('k') | test/mac/gyptest-type-envvars.py » ('j') | no next file with comments »