Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: test/mac/gyptest-app-error.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase onto origin/master Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mac/gyptest-action-envvars.py ('k') | test/mac/gyptest-archs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mac/gyptest-app-error.py
diff --git a/test/mac/gyptest-app-error.py b/test/mac/gyptest-app-error.py
index a62af6b852a815cb325caf430030cb8d10407aa1..8f3cef28c11d154979183e5ef29d2e92d93e0c9f 100755
--- a/test/mac/gyptest-app-error.py
+++ b/test/mac/gyptest-app-error.py
@@ -34,7 +34,8 @@ if sys.platform == 'darwin':
test.build('test-error.gyp', test.ALL, chdir='app-bundle')
# Ninja pipes stderr of subprocesses to stdout.
- if test.format == 'ninja' and expected_error in test.stdout():
+ if test.format in ['ninja', 'xcode-ninja'] \
+ and expected_error in test.stdout():
saw_expected_error[0] = True
if saw_expected_error[0]:
« no previous file with comments | « test/mac/gyptest-action-envvars.py ('k') | test/mac/gyptest-archs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698