Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: test/generator-output/gyptest-actions.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase onto origin/master Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/dependencies/gyptest-lib-only.py ('k') | test/generator-output/gyptest-copies.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/generator-output/gyptest-actions.py
diff --git a/test/generator-output/gyptest-actions.py b/test/generator-output/gyptest-actions.py
index 8c912e492b5afec87108fa3c6d4396eae5c35be6..647d24b951ab466c94ecd8b921b2e38d559e6963 100755
--- a/test/generator-output/gyptest-actions.py
+++ b/test/generator-output/gyptest-actions.py
@@ -13,12 +13,16 @@ import TestGyp
# Android doesn't support --generator-output.
test = TestGyp.TestGyp(formats=['!android'])
+# Bug: xcode-ninja doesn't respect --generator-output
+# cf. https://code.google.com/p/gyp/issues/detail?id=442
+if test.format == 'xcode-ninja':
+ test.skip_test()
+
# All the generated files should go under 'gypfiles'. The source directory
# ('actions') should be untouched.
test.writable(test.workpath('actions'), False)
test.run_gyp('actions.gyp',
'--generator-output=' + test.workpath('gypfiles'),
- '-G', 'xcode_ninja_target_pattern=^pull_in_all_actions$',
chdir='actions')
test.writable(test.workpath('actions'), True)
« no previous file with comments | « test/dependencies/gyptest-lib-only.py ('k') | test/generator-output/gyptest-copies.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698