Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Unified Diff: test/compiler-override/gyptest-compiler-env.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase onto origin/master Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/build-option/gyptest-build.py ('k') | test/compiler-override/gyptest-compiler-env-toolchain.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/compiler-override/gyptest-compiler-env.py
diff --git a/test/compiler-override/gyptest-compiler-env.py b/test/compiler-override/gyptest-compiler-env.py
index 6408ae1161372d75d1072f9b0f91a7c44a4e0c28..bb38b6e55bea9b66ab17393aa4f31475a2b69b7a 100755
--- a/test/compiler-override/gyptest-compiler-env.py
+++ b/test/compiler-override/gyptest-compiler-env.py
@@ -37,7 +37,9 @@ test = TestGyp.TestGyp(formats=['ninja', 'make'])
def TestTargetOveride():
expected = ['my_cc.py', 'my_cxx.py', 'FOO' ]
- if test.format != 'ninja': # ninja just uses $CC / $CXX as linker.
+
+ # ninja just uses $CC / $CXX as linker.
+ if test.format not in ['ninja', 'xcode-ninja']:
expected.append('FOO_LINK')
# Check that CC, CXX and LD set target compiler
@@ -104,6 +106,5 @@ def TestHostOveride():
TestTargetOveride()
TestTargetOverideCompilerOnly()
-TestHostOveride()
test.pass_test()
« no previous file with comments | « test/build-option/gyptest-build.py ('k') | test/compiler-override/gyptest-compiler-env-toolchain.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698