public/web/WebFrameClient.h - Issue 42143002: Make createServiceWorkerProvider stub smarter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebFrameClient.h

Issue 42143002: Make createServiceWorkerProvider stub smarter (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix #include lines and delete Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebFrameClient.h

diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h

index e2e2ce57967c13cb686ea614d2c5c5639d8dfaf0..115b6bc54ef61caa652deab6b5d1d2e14c557843 100644

--- a/public/web/WebFrameClient.h

+++ b/public/web/WebFrameClient.h

@@ -31,11 +31,6 @@

#ifndef WebFrameClient_h

#define WebFrameClient_h

-#include "../platform/WebCommon.h"

-#include "../platform/WebFileSystem.h"

-#include "../platform/WebFileSystemType.h"

-#include "../platform/WebURLError.h"

-#include "../platform/WebURLRequest.h"

#include "WebDOMMessageEvent.h"

#include "WebDataSource.h"

#include "WebIconURL.h"

@@ -44,6 +39,12 @@

#include "WebSecurityOrigin.h"

#include "WebStorageQuotaType.h"

#include "WebTextDirection.h"

+#include "public/platform/WebCommon.h"

+#include "public/platform/WebFileSystem.h"

+#include "public/platform/WebFileSystemType.h"

+#include "public/platform/WebServiceWorkerProviderClient.h"

+#include "public/platform/WebURLError.h"

+#include "public/platform/WebURLRequest.h"

#include <v8.h>

namespace WebKit {

@@ -59,7 +60,6 @@ class WebFrame;

class WebMediaPlayer;

class WebMediaPlayerClient;

class WebServiceWorkerProvider;

-class WebServiceWorkerProviderClient;

class WebNode;

class WebPlugin;

class WebRTCPeerConnectionHandler;

@@ -94,7 +94,7 @@ public:

virtual WebApplicationCacheHost* createApplicationCacheHost(WebFrame*, WebApplicationCacheHostClient*) { return 0; }

// May return null. Takes ownership of the client.

- virtual WebServiceWorkerProvider* createServiceWorkerProvider(WebFrame*, WebServiceWorkerProviderClient*) { return 0; }

+ virtual WebServiceWorkerProvider* createServiceWorkerProvider(WebFrame*, WebServiceWorkerProviderClient* client ) { delete client; return 0; }

abarth-chromium 2013/10/25 15:29:51 I don't think we want to call |delete| in an API h

// Services ------------------------------------------------------------

« no previous file with comments | « no previous file | no next file » | no next file with comments »