Make createServiceWorkerProvider stub smarter

public/web/WebFrameClient.h

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 76 matching lines @@
     // May return null.
     virtual WebSharedWorker* createSharedWorker(WebFrame*, const WebURL&, const WebString&, unsigned long long) { return 0; }
 
     // May return null.
     virtual WebMediaPlayer* createMediaPlayer(WebFrame*, const WebURL&, WebMediaPlayerClient*) { return 0; }
 
     // May return null.
     virtual WebApplicationCacheHost* createApplicationCacheHost(WebFrame*, WebApplicationCacheHostClient*) { return 0; }
 
     // May return null. Takes ownership of the client.
-    virtual WebServiceWorkerProvider* createServiceWorkerProvider(WebFrame*, WebServiceWorkerProviderClient*) { return 0; }
+    virtual WebServiceWorkerProvider* createServiceWorkerProvider(WebFrame*, WebServiceWorkerProviderClient* client )
+    {
+        if (client)
+            delete client;
+        return 0;

[michaeln, 2013/10/24 22:53:37]

might read better as { delete client; return 0; } all on the same line, there's
no harm in calling delete on a null ptr

[alecflett, 2013/10/24 23:06:14]

oh wow, sure enough. apparently the last time I manually 'delete'ed a pointer in
C++ was 2003, when this wasn't true :)

+    }
 
 
     // Services ------------------------------------------------------------
 
     // A frame specific cookie jar.  May return null, in which case
     // WebKitPlatformSupport::cookieJar() will be called to access cookies.
     virtual WebCookieJar* cookieJar(WebFrame*) { return 0; }
 
 
     // General notifications -----------------------------------------------
@@ skipping 265 matching lines @@
     // Extensions3D.h in WebCore/platform/graphics).
     virtual void didLoseWebGLContext(WebFrame*, int) { }
 
 protected:
     ~WebFrameClient() { }
 };
 
 } // namespace WebKit
 
 #endif