Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 421423002: Rebaseline needed nvpr gms after text change (Closed)

Created:
6 years, 4 months ago by Chris Dalton
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rebaseline needed nvpr gms after text change Updates a few nvpr expectations for slight pixel diffs after a change in the math that positions glyphs. BUG=skia: Committed: https://skia.googlesource.com/skia/+/15ab26d94242a790230aee6f2c4889bca910c8f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -39 lines) Patch
M expectations/gm/Test-Android-Logan-Nvidia-Arm7-Debug/expected-results.json View 1 chunk +63 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Logan-Nvidia-Arm7-Release/expected-results.json View 1 chunk +63 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 3 chunks +65 lines, -5 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 3 chunks +65 lines, -5 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 3 chunks +65 lines, -5 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 3 chunks +65 lines, -5 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 3 chunks +65 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 3 chunks +65 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 3 chunks +65 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 3 chunks +65 lines, -2 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Chris Dalton
6 years, 4 months ago (2014-07-28 22:23:26 UTC) #1
bungeman-skia
rubber stamp lgtm
6 years, 4 months ago (2014-07-28 22:26:09 UTC) #2
Chris Dalton
The CQ bit was checked by cdalton@nvidia.com
6 years, 4 months ago (2014-07-28 22:27:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/421423002/1
6 years, 4 months ago (2014-07-28 22:27:32 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 22:39:12 UTC) #5
Message was sent while issue was closed.
Change committed as 15ab26d94242a790230aee6f2c4889bca910c8f7

Powered by Google App Engine
This is Rietveld 408576698