Issue 421383002: Fix loop condition in BidiRunList::replaceRunWithRuns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 421383002: Fix loop condition in BidiRunList::replaceRunWithRuns (Closed)

Created:
6 years, 4 months ago by eae

Modified:
6 years, 4 months ago

Reviewers:
leviw_travelin_and_unemployed, inferno

CC:
blink-reviews, leviw+bidiwatch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Fix loop condition in BidiRunList::replaceRunWithRuns Fix the loop condition in BidiRunList::replaceRunWithRuns to check if a next run exists before accessing it. R=inferno@chromium.org BUG=397479 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179068

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
A	LayoutTests/fast/text/bidi-replace-runs-crash.html	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/text/bidi-replace-runs-crash-expected.txt	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/platform/text/BidiRunList.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (0 generated)

aarya

On 2014/07/28 21:09:13, eae wrote: I don't know the Bidi code at all. Can you ...

6 years, 4 months ago (2014-07-28 21:11:24 UTC) #2

leviw_travelin_and_unemployed

Do you have a test case that exercises this? The change seems entirely reasonable.

6 years, 4 months ago (2014-07-28 21:13:06 UTC) #3

eae

On 2014/07/28 21:13:06, leviw wrote: > Do you have a test case that exercises this? ...

6 years, 4 months ago (2014-07-28 21:29:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/421383002/20001

6 years, 4 months ago (2014-07-28 21:32:05 UTC) #6

Message was sent while issue was closed.

Change committed as 179068