Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 421373002: Do not set background priority in-process on Windows (Closed)

Created:
6 years, 4 months ago by Will Harris
Modified:
6 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Do not set background priority in-process on Windows, when tabs are backgrounded. BUG=381820, 398103 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286195

Patch Set 1 : this is just a revert of 420603014 #

Patch Set 2 : do not set priority from within child process #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M content/browser/child_process_launcher.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/child/child_thread.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Will Harris
This CL reverts 420603014, as it was breaking Android tests, and replaces it with a ...
6 years, 4 months ago (2014-07-28 21:31:51 UTC) #1
Will Harris
On 2014/07/28 21:31:51, Will Harris wrote: > This CL reverts 420603014, as it was breaking ...
6 years, 4 months ago (2014-07-29 01:34:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-29 08:55:48 UTC) #3
mlamouri (slow - plz ping)
On 2014/07/29 08:55:48, jochen wrote: > lgtm This CL fixes a breakage in Chrome Android. ...
6 years, 4 months ago (2014-07-29 11:09:27 UTC) #4
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-07-29 11:11:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/421373002/20001
6 years, 4 months ago (2014-07-29 11:11:59 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 14:46:16 UTC) #7
Message was sent while issue was closed.
Change committed as 286195

Powered by Google App Engine
This is Rietveld 408576698