Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: content/renderer/renderer_webkitplatformsupport_impl.h

Issue 421293010: Update RendererWebPlatformSupportImpl to use {start,stop}Listening(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/renderer_webkitplatformsupport_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/renderer_webkitplatformsupport_impl.h
diff --git a/content/renderer/renderer_webkitplatformsupport_impl.h b/content/renderer/renderer_webkitplatformsupport_impl.h
index f575ab4fce8749a8bca43e679fbd957a5840fa7b..209da825f3357dd5a7321d1b97d83eb230b7e0e9 100644
--- a/content/renderer/renderer_webkitplatformsupport_impl.h
+++ b/content/renderer/renderer_webkitplatformsupport_impl.h
@@ -120,7 +120,6 @@ class CONTENT_EXPORT RendererWebKitPlatformSupportImpl
virtual blink::WebBlobRegistry* blobRegistry();
virtual void sampleGamepads(blink::WebGamepads&);
- virtual void setGamepadListener(blink::WebGamepadListener*);
virtual blink::WebRTCPeerConnectionHandler* createRTCPeerConnectionHandler(
blink::WebRTCPeerConnectionHandlerClient* client);
virtual blink::WebMediaStreamCenter* createMediaStreamCenter(
@@ -137,19 +136,15 @@ class CONTENT_EXPORT RendererWebKitPlatformSupportImpl
virtual blink::WebCompositorSupport* compositorSupport();
virtual blink::WebString convertIDNToUnicode(
const blink::WebString& host, const blink::WebString& languages);
- virtual void setDeviceLightListener(blink::WebDeviceLightListener* listener);
- virtual void setDeviceMotionListener(
- blink::WebDeviceMotionListener* listener);
- virtual void setDeviceOrientationListener(
- blink::WebDeviceOrientationListener* listener);
+ virtual void startListening(blink::WebPlatformEventType,
+ blink::WebPlatformEventListener*);
+ virtual void stopListening(blink::WebPlatformEventType);
virtual void queryStorageUsageAndQuota(
const blink::WebURL& storage_partition,
blink::WebStorageQuotaType,
blink::WebStorageQuotaCallbacks);
virtual void vibrate(unsigned int milliseconds);
virtual void cancelVibration();
- virtual void setBatteryStatusListener(
- blink::WebBatteryStatusListener* listener);
void set_gamepad_provider(RendererGamepadProvider* provider) {
gamepad_provider_ = provider;
@@ -185,6 +180,15 @@ class CONTENT_EXPORT RendererWebKitPlatformSupportImpl
private:
bool CheckPreparsedJsCachingEnabled() const;
+ // Implement those methods internally so startListening() and stopListening()
+ // are being used and Blink can change its interface.
+ void SetDeviceMotionListener(blink::WebDeviceMotionListener*);
+ void SetDeviceOrientationListener(blink::WebDeviceOrientationListener*);
+ void SetDeviceLightListener(blink::WebDeviceLightListener*);
+ void SetBatteryStatusListener(blink::WebBatteryStatusListener*);
+ void SetGamepadListener(blink::WebGamepadListener*);
+
+
scoped_ptr<RendererClipboardClient> clipboard_client_;
scoped_ptr<WebClipboardImpl> clipboard_;
« no previous file with comments | « no previous file | content/renderer/renderer_webkitplatformsupport_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698