Issue 421293010: Update RendererWebPlatformSupportImpl to use {start,stop}Listening().

Issue 421293010: Update RendererWebPlatformSupportImpl to use {start,stop}Listening(). (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update RendererWebPlatformSupportImpl to use {start,stop}Listening(). It doesn't do anything fancy but allows Blink to stop supporting the previous API. BUG=400158 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288060

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -71 lines)			Patch
	M	content/renderer/renderer_webkitplatformsupport_impl.h	View		3 chunks	+12 lines, -8 lines	0 comments	Download
	M	content/renderer/renderer_webkitplatformsupport_impl.cc	View	1	6 chunks	+123 lines, -63 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm https://codereview.chromium.org/421293010/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc File content/renderer/renderer_webkitplatformsupport_impl.cc (right): https://codereview.chromium.org/421293010/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc#newcode1106 content/renderer/renderer_webkitplatformsupport_impl.cc:1106: LOG(ERROR) << "RendererWebKitPlatformSupportImpl::stopListening() with " VLOG(1) ?

6 years, 4 months ago (2014-08-04 12:44:20 UTC) #2

mlamouri (slow - plz ping)

https://codereview.chromium.org/421293010/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc File content/renderer/renderer_webkitplatformsupport_impl.cc (right): https://codereview.chromium.org/421293010/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc#newcode1106 content/renderer/renderer_webkitplatformsupport_impl.cc:1106: LOG(ERROR) << "RendererWebKitPlatformSupportImpl::stopListening() with " On 2014/08/04 12:44:20, jochen ...

6 years, 4 months ago (2014-08-04 14:28:44 UTC) #3

mlamouri (slow - plz ping)

The CQ bit was checked by mlamouri@chromium.org

6 years, 4 months ago (2014-08-07 09:38:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/421293010/20001

6 years, 4 months ago (2014-08-07 09:40:04 UTC) #6

Message was sent while issue was closed.

Change committed as 288060

Expand Messages | Collapse Messages