Source/core/dom/Position.cpp - Issue 421293004: Move Node::enclosingBlockFlowElement() to htmlediting.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Position.cpp

Issue 421293004: Move Node::enclosingBlockFlowElement() to htmlediting.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Position.cpp

diff --git a/Source/core/dom/Position.cpp b/Source/core/dom/Position.cpp

index f40b584c220fcac922d3a32ff2eba68369ba0b9e..77a0917607d47f16916ac8a9f506f64e9160cbf2 100644

--- a/Source/core/dom/Position.cpp

+++ b/Source/core/dom/Position.cpp

@@ -948,7 +948,7 @@ bool Position::rendersInDifferentPosition(const Position &pos) const

if (isHTMLBRElement(*pos.deprecatedNode()) && isCandidate())

return true;

- if (deprecatedNode()->enclosingBlockFlowElement() != pos.deprecatedNode()->enclosingBlockFlowElement())

+ if (enclosingBlockFlowElement(*deprecatedNode()) != enclosingBlockFlowElement(*pos.deprecatedNode()))

leviw_travelin_and_unemployed 2014/07/28 21:39:56 !inSameContainingBlockFlowElement(*deprecatedNode(

Inactive 2014/07/28 21:47:11 Done.

return true;

if (deprecatedNode()->isTextNode() && !inRenderedText())