Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 421293004: Move Node::enclosingBlockFlowElement() to htmlediting.h (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Move Node::enclosingBlockFlowElement() to htmlediting.h Move Node::enclosingBlockFlowElement() / inSameContainingBlockFlowElement() to htmlediting.h as this is only needed for editing. R=leviw@chromium.org, yosin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179081

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -33 lines) Patch
M Source/core/dom/Node.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +0 lines, -21 lines 0 comments Download
M Source/core/dom/Position.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/421293004/diff/1/Source/core/dom/Position.cpp File Source/core/dom/Position.cpp (right): https://codereview.chromium.org/421293004/diff/1/Source/core/dom/Position.cpp#newcode951 Source/core/dom/Position.cpp:951: if (enclosingBlockFlowElement(*deprecatedNode()) != enclosingBlockFlowElement(*pos.deprecatedNode())) !inSameContainingBlockFlowElement(*deprecatedNode(), *pos.deprecatedNode())? https://codereview.chromium.org/421293004/diff/1/Source/core/dom/Position.cpp#newcode951 Source/core/dom/Position.cpp:951: ...
6 years, 4 months ago (2014-07-28 21:39:56 UTC) #1
Inactive
https://codereview.chromium.org/421293004/diff/1/Source/core/dom/Position.cpp File Source/core/dom/Position.cpp (right): https://codereview.chromium.org/421293004/diff/1/Source/core/dom/Position.cpp#newcode951 Source/core/dom/Position.cpp:951: if (enclosingBlockFlowElement(*deprecatedNode()) != enclosingBlockFlowElement(*pos.deprecatedNode())) On 2014/07/28 21:39:56, leviw wrote: ...
6 years, 4 months ago (2014-07-28 21:47:11 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-28 22:16:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/421293004/20001
6 years, 4 months ago (2014-07-28 22:17:30 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-29 00:08:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 00:20:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19343)
6 years, 4 months ago (2014-07-29 00:20:48 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-29 00:36:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/421293004/20001
6 years, 4 months ago (2014-07-29 00:37:31 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-29 01:19:00 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 01:52:40 UTC) #11
Message was sent while issue was closed.
Change committed as 179081

Powered by Google App Engine
This is Rietveld 408576698