Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: Source/core/html/HTMLTableElement.cpp

Issue 421263002: Deprecate the hspace/vspace attributes on table (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/UseCounter.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 imageValue->setReferrer(Referrer(document().outgoingReferrer(), docu ment().referrerPolicy())); 314 imageValue->setReferrer(Referrer(document().outgoingReferrer(), docu ment().referrerPolicy()));
315 style->setProperty(CSSProperty(CSSPropertyBackgroundImage, imageValu e.release())); 315 style->setProperty(CSSProperty(CSSPropertyBackgroundImage, imageValu e.release()));
316 } 316 }
317 } else if (name == valignAttr) { 317 } else if (name == valignAttr) {
318 if (!value.isEmpty()) 318 if (!value.isEmpty())
319 addPropertyToPresentationAttributeStyle(style, CSSPropertyVerticalAl ign, value); 319 addPropertyToPresentationAttributeStyle(style, CSSPropertyVerticalAl ign, value);
320 } else if (name == cellspacingAttr) { 320 } else if (name == cellspacingAttr) {
321 if (!value.isEmpty()) 321 if (!value.isEmpty())
322 addHTMLLengthToStyle(style, CSSPropertyBorderSpacing, value); 322 addHTMLLengthToStyle(style, CSSPropertyBorderSpacing, value);
323 } else if (name == vspaceAttr) { 323 } else if (name == vspaceAttr) {
324 UseCounter::count(document(), UseCounter::HTMLTableElementVspace); 324 UseCounter::countDeprecation(document(), UseCounter::HTMLTableElementVsp ace);
325 addHTMLLengthToStyle(style, CSSPropertyMarginTop, value); 325 addHTMLLengthToStyle(style, CSSPropertyMarginTop, value);
326 addHTMLLengthToStyle(style, CSSPropertyMarginBottom, value); 326 addHTMLLengthToStyle(style, CSSPropertyMarginBottom, value);
327 } else if (name == hspaceAttr) { 327 } else if (name == hspaceAttr) {
328 UseCounter::count(document(), UseCounter::HTMLTableElementHspace); 328 UseCounter::countDeprecation(document(), UseCounter::HTMLTableElementHsp ace);
329 addHTMLLengthToStyle(style, CSSPropertyMarginLeft, value); 329 addHTMLLengthToStyle(style, CSSPropertyMarginLeft, value);
330 addHTMLLengthToStyle(style, CSSPropertyMarginRight, value); 330 addHTMLLengthToStyle(style, CSSPropertyMarginRight, value);
331 } else if (name == alignAttr) { 331 } else if (name == alignAttr) {
332 if (!value.isEmpty()) { 332 if (!value.isEmpty()) {
333 if (equalIgnoringCase(value, "center")) { 333 if (equalIgnoringCase(value, "center")) {
334 addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkit MarginStart, CSSValueAuto); 334 addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkit MarginStart, CSSValueAuto);
335 addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkit MarginEnd, CSSValueAuto); 335 addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkit MarginEnd, CSSValueAuto);
336 } else 336 } else
337 addPropertyToPresentationAttributeStyle(style, CSSPropertyFloat, value); 337 addPropertyToPresentationAttributeStyle(style, CSSPropertyFloat, value);
338 } 338 }
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
576 return getAttribute(summaryAttr); 576 return getAttribute(summaryAttr);
577 } 577 }
578 578
579 void HTMLTableElement::trace(Visitor* visitor) 579 void HTMLTableElement::trace(Visitor* visitor)
580 { 580 {
581 visitor->trace(m_sharedCellStyle); 581 visitor->trace(m_sharedCellStyle);
582 HTMLElement::trace(visitor); 582 HTMLElement::trace(visitor);
583 } 583 }
584 584
585 } 585 }
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698