Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java

Issue 421253006: Add ChromeCodingConvention.java to Closure Compiler to preserve getInstance() type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@A_typechecking_about
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java
diff --git a/third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java b/third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java
index c94913127e0ed7fd0ae126f6f7a5980df08d094d..54cbd6a02bb54bb4a2b96053d1a1178079e85e4a 100644
--- a/third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java
+++ b/third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java
@@ -12,6 +12,8 @@ import org.kohsuke.args4j.CmdLineException;
import org.kohsuke.args4j.CmdLineParser;
import org.kohsuke.args4j.Option;
+import org.chromium.closure.compiler.ChromeCodingConvention;
+
import java.io.BufferedReader;
import java.io.ByteArrayOutputStream;
import java.io.FileInputStream;
@@ -189,6 +191,13 @@ public class Runner {
return options;
}
+ @Override
+ protected void setRunOptions(CompilerOptions options)
+ throws FlagUsageException, IOException {
Dan Beam 2014/07/29 18:05:12 4 more \s indent on L196
Vitaly Pavlenko 2014/07/29 18:53:46 Done.
+ super.setRunOptions(options);
+ options.setCodingConvention(new ChromeCodingConvention());
+ }
+
int execute() {
int result = 0;
int runs = 1;

Powered by Google App Engine
This is Rietveld 408576698