Fixes to the SHA256 X509 Certificate fingerprint API.

net/cert/x509_certificate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/x509_certificate.h"
 
 #include <stdlib.h>
 
 #include <algorithm>
 #include <map>
@@ skipping 702 matching lines @@
   SHA256HashValue sha256;
   memset(sha256.data, 0, sizeof(sha256.data));
 
   scoped_ptr<crypto::SecureHash> hash(
       crypto::SecureHash::Create(crypto::SecureHash::SHA256));
 
   for (size_t i = 0; i < intermediates.size(); ++i) {
     std::string der_encoded;
     if (!GetDEREncoded(intermediates[i], &der_encoded))
       return sha256;
-    hash->Update(der_encoded.c_str(), der_encoded.length());
+    hash->Update(der_encoded.data(), der_encoded.length());
   }
   hash->Finish(sha256.data, sizeof(sha256.data));
 
   return sha256;
 }
 
 // static
 SHA256HashValue X509Certificate::CalculateChainFingerprint256(
-    const OSCertHandle& leaf,
+    OSCertHandle leaf,
     const OSCertHandles& intermediates) {
   OSCertHandles chain;
   chain.push_back(leaf);
   chain.insert(chain.end(), intermediates.begin(), intermediates.end());
 
   return CalculateCAFingerprint256(chain);
 }
 
 X509Certificate::X509Certificate(OSCertHandle cert_handle,
                                  const OSCertHandles& intermediates)
@@ skipping 17 matching lines @@
     RemoveFromCache(cert_handle_);
     FreeOSCertHandle(cert_handle_);
   }
   for (size_t i = 0; i < intermediate_ca_certs_.size(); ++i) {
     RemoveFromCache(intermediate_ca_certs_[i]);
     FreeOSCertHandle(intermediate_ca_certs_[i]);
   }
 }
 
 }  // namespace net