Fixes to the SHA256 X509 Certificate fingerprint API.

net/cert/x509_certificate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_X509_CERTIFICATE_H_
 #define NET_CERT_X509_CERTIFICATE_H_
 
 #include <string.h>
 
 #include <string>
@@ skipping 387 matching lines @@
   // Calculates the SHA-1 fingerprint of the intermediate CA certificates.
   // Returns an empty (all zero) fingerprint on failure.
   //
   // See SHA-1 caveat on CalculateFingerprint().
   static SHA1HashValue CalculateCAFingerprint(
       const OSCertHandles& intermediates);
 
   // Calculates the SHA-256 fingerprint of the intermediate CA certificates.
   // Returns an empty (all zero) fingerprint on failure.
   //
-  // The implementation currently relies on the crypto::SecureHash utilities,
-  // which are not as fast as implementing this directly for each platform since
-  // the consumers are not expected to be performance critical. If performance
-  // is a concern going forward, it may be warranted to implement this on a
-  // per-platform basis.
+  // As part of the cross-platform implementation of this function, it currently
+  // copies the certificate bytes into local variables which makes it
+  // potentially slower than implementing it directly for each platform. For
+  // now, the expected consumers are not performance critical, but if
+  // performance is a concern going forward, it may warrant implementing this on
+  // a per-platform basis.
   static SHA256HashValue CalculateCAFingerprint256(
       const OSCertHandles& intermediates);
 
   // Calculates the SHA-256 fingerprint for the complete chain, including the
   // leaf certificate and all intermediate CA certificates. Returns an empty
   // (all zero) fingerprint on failure.
   static SHA256HashValue CalculateChainFingerprint256(
-      const OSCertHandle& leaf,
+      OSCertHandle leaf,
       const OSCertHandles& intermediates);
 
  private:
   friend class base::RefCountedThreadSafe<X509Certificate>;
   friend class TestRootCerts;  // For unit tests
 
   FRIEND_TEST_ALL_PREFIXES(X509CertificateNameVerifyTest, VerifyHostname);
   FRIEND_TEST_ALL_PREFIXES(X509CertificateTest, SerialNumbers);
 
   // Construct an X509Certificate from a handle to the certificate object
@@ skipping 78 matching lines @@
   // based on the type of the certificate.
   std::string default_nickname_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(X509Certificate);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_X509_CERTIFICATE_H_